Skip to content

Graceful shutdown if block hash from feed mismatches with locally computed one #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Graceful shutdown if block hash from feed mismatches with locally computed one #3859

wants to merge 2 commits into from
+22 −15

Conversation

ganeshvanahalli
Copy link
Contributor

This PR adds a new boolean config option --node.transaction-streamer.shutdown-on-blockhash-mismatch which when set would lead to a graceful shutdown of node if the block hash received from feed doesn't match with the locally computed one.

Resolves NIT-2500

KolbyML
KolbyML previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
2144 5 2139 0
View the top 3 failed tests by shortest run time 
TestRedisProduceComplex/one_producer,_all_consumers_are_active
Stack Traces | 1.180s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[10-16|17:56:26.439] consumer: xack                           �[36mcid�[0m=da6689b8-8af9-4815-9518-aa2eb279e6f1 �[36mmessageId�[0m=1760637385340-3
�[33mWARN �[0m[10-16|17:56:26.440] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1760637385329-10
�[36mDEBUG�[0m[10-16|17:56:26.439] consumer: xack                           �[36mcid�[0m=0bcd41ce-69d0-40e8-bd43-6a4a5224a887 �[36mmessageId�[0m=1760637385340-5
�[36mDEBUG�[0m[10-16|17:56:26.441] consumer: xack                           �[36mcid�[0m=176d70cb-3fd0-45aa-86b6-78be12f1cbdb �[36mmessageId�[0m=1760637385340-4
�[36mDEBUG�[0m[10-16|17:56:26.441] consumer: xack                           �[36mcid�[0m=1e43ede3-527c-4912-bf30-3d900111536f �[36mmessageId�[0m=1760637385341-0
�[36mDEBUG�[0m[10-16|17:56:26.460] checkResponses                           �[36mresponded�[0m=65 �[36merrored�[0m=0 �[36mchecked�[0m=100
�[36mDEBUG�[0m[10-16|17:56:26.465] redis producer: check responses starting
�[36mDEBUG�[0m[10-16|17:56:26.487] checkResponses                           �[36mresponded�[0m=35 �[36merrored�[0m=0 �[36mchecked�[0m=35
�[31mERROR�[0m[10-16|17:56:26.489] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[31mERROR�[0m[10-16|17:56:26.489] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[31mERROR�[0m[10-16|17:56:26.492] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[36mDEBUG�[0m[10-16|17:56:26.493] redis producer: check responses starting
�[36mDEBUG�[0m[10-16|17:56:26.493] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=0
�[31mERROR�[0m[10-16|17:56:26.494] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[31mERROR�[0m[10-16|17:56:26.495] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[31mERROR�[0m[10-16|17:56:26.497] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[31mERROR�[0m[10-16|17:56:26.497] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
�[31mERROR�[0m[10-16|17:56:26.499] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
    pubsub_test.go:331: mergeMaps() unexpected error: duplicate key: 1760637385325-5
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (1.18s)

TestValidationInputsAtWithWasmTarget
Stack Traces | 2.580s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90m97	1	DUP4	[0x1 0xa4 0x60 0x1 0x60 0x0 0x0 0x66 0x1 0xa4 0x4 0x0 0x0 0x0]�[0;0m
�[90m98	1	PUSH1	[0x1 0xa4 0x60 0x1 0x60 0x0 0x0 0x66 0x1 0xa4 0x4 0x0 0x0 0x0 0x4]�[0;0m
�[90m99	1	AND	[0x1 0xa4 0x60 0x1 0x60 0x0 0x0 0x66 0x1 0xa4 0x4 0x0 0x0 0x0 0x4 0xff]�[0;0m
�[90m100	1	DUP2	[0x1 0xa4 0x60 0x1 0x60 0x0 0x0 0x66 0x1 0xa4 0x4 0x0 0x0 0x0 0x4]�[0;0m
�[90m101	1	PUSH1	[0x1 0xa4 0x60 0x1 0x60 0x0 0x0 0x66 0x1 0xa4 0x4 0x0 0x0 0x0 0x4 0x0]�[0;0m
ERROR[10-16|18:04:40.350] Dangling trie nodes after full cleanup
�[90mTime to activate panic-after-write: 173.675489ms�[0;0m
�[90mCall trace:�[0;0m
�[90mi	depth	opcode	stack�[0;0m
�[90m0	1	SLOAD	[0x15fed0451499512d95f3ec5a41c878b9de55f21878b5b4e190d4667ec709b400]�[0;0m
�[90m1	1	SLOAD	[0x3c79da47f96b0f39664f73c0a1f350580be90742947dddfa21ba64d578dfe600]�[0;0m
�[90m2	1	CALLDATACOPY	[0x0 0x0 0x0]�[0;0m
�[90m3	1	REVERT	[0x12 0x0]�[0;0m
�[90m4	1	STOP	[]�[0;0m
ERROR[10-16|18:04:40.362] Dangling trie nodes after full cleanup
ERROR[10-16|18:04:40.362] Dangling trie nodes after full cleanup
ERROR[10-16|18:04:40.368] Dangling trie nodes after full cleanup
INFO [10-16|18:04:40.380] HTTP server stopped                      endpoint=127.0.0.1:42569
TRACE[10-16|18:04:40.380] P2P networking is spinning down
--- FAIL: TestValidationInputsAtWithWasmTarget (2.58s)

TestRedisProduceComplex
Stack Traces | 9.840s run time 
=== RUN   TestRedisProduceComplex
=== PAUSE TestRedisProduceComplex
=== CONT  TestRedisProduceComplex
--- FAIL: TestRedisProduceComplex (9.84s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

KolbyML
KolbyML approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KolbyML KolbyML KolbyML approved these changes

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees

@joshuacolvin0 joshuacolvin0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ganeshvanahalli @KolbyML @joshuacolvin0 @Tristan-Wilson